Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more like prettyDiff? #52

Open
tnrich opened this issue Jan 30, 2016 · 3 comments
Open

Be more like prettyDiff? #52

tnrich opened this issue Jan 30, 2016 · 3 comments

Comments

@tnrich
Copy link

tnrich commented Jan 30, 2016

Here's how prettydiff is (at a high level) handling JSX:
http://prettydiff.com/guide/react_jsx.xhtml

It seems to be the best JSX formatter that I've encountered thus far. Any chance you're doing something differently?

@royriojas
Copy link
Owner

hi @tnrich, interesting, I have been considering to switch to jsbeautify directly since they now support jsx as well.

But I would like to understand exactly what are the issues you're found using last version esformatter-jsx? If you can be specific it would be awesome. Will take a look a prettydiff as well.

@tnrich
Copy link
Author

tnrich commented Jan 30, 2016

The main thing is esformatter-jsx doesn't seem to handle javascript
expression within jsx very well.

On Sat, Jan 30, 2016 at 9:32 AM Roy Riojas [email protected] wrote:

hi @tnrich https://github.com/tnrich, interesting, I have been
considering to switch to jsbeautify http://jsbeautifier.org/ directly
since they now support jsx as well.

But I would like to understand exactly what are the issues you're found
using last version esformatter-jsx? If you can be specific it would be
awesome. Will take a look a prettydiff as well.


Reply to this email directly or view it on GitHub
#52 (comment)
.

@royriojas
Copy link
Owner

Yes, I know. There are some improvements in the queue specifically for that. Do you have any specific code block that is failing? just curious?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants