Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Foxy Support #59

Open
edgarcamilocamacho opened this issue Oct 22, 2021 · 4 comments · May be fixed by #60
Open

Foxy Support #59

edgarcamilocamacho opened this issue Oct 22, 2021 · 4 comments · May be fixed by #60
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@edgarcamilocamacho
Copy link

Hello. Should the package work on ROS2 Foxy? When I try to manually build it I get some CMake related errors, and I don't see any foxy related branch.

@jacobperron
Copy link
Member

This package was initially developed with ROS Galactic in mind, and I'm not sure if it ever successfully built for Foxy.

I'm not sure I have the time to investigate support for Foxy, but if someone would like to try I suggest starting from the galactic branch and trying to adapt it to work with Foxy.

@jacobperron jacobperron added enhancement New feature or request help wanted Extra attention is needed labels Oct 23, 2021
@aprotyas
Copy link
Member

aprotyas commented Oct 23, 2021

I looked into this. The CMake issue doesn't exist in the galactic branch - it was about rosidl_get_typesupport_target.

I believe this package can't be supported for Foxy without a lot of work, because domain_bridge::DomainBridgeImpl requires rclcpp::GenericPublisher/rclcpp::GenericSubscription, and I'm fairly certain that ros2/rclcpp#1452 can't be backported to Foxy.

#include "rclcpp/generic_publisher.hpp"
#include "rclcpp/generic_subscription.hpp"

@jacobperron
Copy link
Member

@aprotyas If we go back into the commit history of the domain_bridge, you'll find that we used to have a copy of rclcpp::GenericPublisher and rclcpp::GenericSubscription in this repository (since it predates their addition in rclcpp). So, if someone wanted to try, they could add copies of those classes back to this repo for Foxy support.

Tag 0.3.0 has it's own generic pub/sub classes: https://github.com/ros2/domain_bridge/tree/0.3.0/src/domain_bridge

@aprotyas
Copy link
Member

aprotyas commented Oct 28, 2021

So, if someone wanted to try, they could add copies of those classes back to this repo for Foxy support.

That makes sense!

I would've started myself, but I'm not sure if this is how the workflow would look like - can you push a foxy branch to this repo against which I can then open a draft PR? I'll be pushing some changes to the aprotyas/add_foxy_support branch for now regardless.

@aprotyas aprotyas linked a pull request Oct 28, 2021 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants