Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more tests CallFunc. #883

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vgvassilev
Copy link
Member

@phsft-bot
Copy link

Starting build on ROOT-debian10-i386/soversion, ROOT-performance-centos8-multicore/cxx17, ROOT-ubuntu18.04/nortcxxmod, ROOT-ubuntu2004/python3, mac1015/cxx17, mac11/cxx14, windows10/cxx14
How to customize builds

@phsft-bot
Copy link

@phsft-bot
Copy link

Build failed on mac1015/cxx17.
Running on macitois21.dyndns.cern.ch:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2022-07-04T23:21:26.805Z] /Volumes/HD2/build/workspace/roottest-pullrequests-build/root/core/metacling/test/TClingCallFuncTests.cxx:311:21: warning: loop variable 'fn' is always a copy because the range of type 'const TCollection' does not return a reference [-Wrange-loop-analysis]

Failing tests:

@phsft-bot
Copy link

Build failed on mac11/cxx14.
Running on macphsft23.dyndns.cern.ch:/Users/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Warnings:

  • [2022-07-05T00:45:23.244Z] /Users/sftnight/build/workspace/roottest-pullrequests-build/root/core/metacling/test/TClingCallFuncTests.cxx:311:21: warning: loop variable 'fn' binds to a temporary value produced by a range of type 'const TCollection' [-Wrange-loop-bind-reference]

Failing tests:

@phsft-bot
Copy link

Build failed on ROOT-debian10-i386/soversion.
Running on pcepsft11.dyndns.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Failing tests:

Copy link
Member

@dpiparo dpiparo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for increasing the coverage! For some reason this PR was left behind unmerged: could you verify it still works and then merge it at your convenience, @vgvassilev ?

@vgvassilev
Copy link
Member Author

@phsft-bot build!

@phsft-bot
Copy link

Starting build on ROOT-performance-centos8-multicore/soversion, ROOT-ubuntu2204/nortcxxmod, ROOT-ubuntu2004/python3, mac12arm/cxx20, windows10/default
How to customize builds

@phsft-bot
Copy link

Build failed on ROOT-ubuntu2004/python3.
Running on root-ubuntu-2004-1.cern.ch:/home/sftnight/build/workspace/roottest-pullrequests-build
See console output.

Errors:

  • [2024-01-04T11:43:58.077Z] FAILED: roottest/root/roofitstats/vectorisedPDFs/CMakeFiles/VectorisedPDFTests.dir/VectorisedPDFTests.cxx.o
  • [2024-01-04T11:43:59.004Z] /home/sftnight/build/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:31:10: fatal error: ../src/RooFit/BatchModeDataHelpers.h: No such file or directory

@phsft-bot
Copy link

Build failed on ROOT-performance-centos8-multicore/soversion.
Running on olbdw-01.cern.ch:/data/sftnight/workspace/roottest-pullrequests-build
See console output.

Errors:

  • [2024-01-04T11:55:18.569Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/testGaussBinned.cxx:84:33: error: ‘BatchMode’ is not a member of ‘RooFit’
  • [2024-01-04T11:55:18.569Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/testGaussBinned.cxx:102:33: error: ‘BatchMode’ is not a member of ‘RooFit’
  • [2024-01-04T11:55:18.569Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/testGaussBinned.cxx:122:33: error: ‘BatchMode’ is not a member of ‘RooFit’
  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:205:18: error: ‘const class RooAbsPdf’ has no member named ‘getValues’; did you mean ‘getValV’?
  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:219:15: error: ‘RooSpan’ was not declared in this scope
  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:219:35: error: template argument 1 is invalid
  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:219:35: error: template argument 2 is invalid
  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:225:10: error: ‘void outputsBatch’ has incomplete type
  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:228:18: error: request for member ‘emplace_back’ in ‘batchResults’, which is of non-class type ‘int’
  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:235:55: error: request for member ‘begin’ in ‘batchResults’, which is of non-class type ‘int’

And 14 more

Warnings:

  • [2024-01-04T11:55:19.336Z] /data/sftnight/workspace/roottest-pullrequests-build/roottest/root/roofitstats/vectorisedPDFs/VectorisedPDFTests.cxx:236:22: warning: unused parameter ‘acc’ [-Wunused-parameter]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants