Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debugging graphic tests in roottest #1153

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file modified graphics/json_ref/AtlasExample.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/BreitWigner.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/CrystalBall.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/DynamicSlice.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/Fibonacci.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/GammaFun.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/NormalizeHistogram.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/TSVDUnfoldExample.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ZoomHistogram.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/analyze.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/annotation3d.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/approx.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/archi.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/arrows.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/basic3d.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/candledecay.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/candleplot.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/candleplotstack.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/candleplotwhiskers.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/candlescaled.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/canvas.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/chi2test.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/compile.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/crown.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ellipse.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/eval.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/event.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/exclusiongraph.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/exclusiongraph2.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/feynman.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/fillhistosauto2p.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/fillrandom.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/first.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/formula1.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/framework.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/gaussian_ratio_plot.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/gaxis.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/gaxis3.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/gerrors.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/gerrors2.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/gmultierrors.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graph.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graph2derrorsfit.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graphApply.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graphShade.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graphpolar.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graphpolar2.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graphpolar3.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/graphreverse.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/greyscale.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/h2_cut.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/h2proj.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/histpalettecolor.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/hksimple.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/hlGraph1.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/hlHisto1.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/hlHisto2.json.zip
Binary file not shown.
Binary file removed graphics/json_ref/hlHisto4.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/hlabels1.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/hlquantiles.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/hstack.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/labels1.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/labels2.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/latex.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/latex2.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/latex3.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/latex4.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/latex5.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/legendautoplaced.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/logscales.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/markerwarning.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/mass_spectrum.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/mathBeta.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/mathGammaNormal.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/mathLaplace.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/mathStudent.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/mathcoreCDF.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/mathcoreStatFunc.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/movepalette.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/multicolor.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/multigraph.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/normalDist.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/pavetext.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/piechart.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/quantiles.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/quarks.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ratioplot1.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ratioplot2.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ratioplot3.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ratioplot4.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ratioplot5.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ratioplot6.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/ratioplotOld.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/rebin.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/reverseaxis.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/scatter.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/schroedinger_hydrogen.json.zip
Binary file not shown.
Binary file removed graphics/json_ref/statsEditing.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/surfaces.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/testSmooth.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/th2polyBoxes.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/th2polyEurope.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/th2polyHoneycomb.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/th2polyUSA.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/timeonaxis.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/timeonaxis2.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/timeonaxis3.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/tmathtext.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/tmathtext2.json.zip
Binary file not shown.
Binary file removed graphics/json_ref/transpad.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/transparency.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/triangles.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/twoscales.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/vavilov.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/waves.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/xyplot.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/zdemo.json.zip
Binary file not shown.
Binary file modified graphics/json_ref/zones.json.zip
Binary file not shown.
29 changes: 22 additions & 7 deletions graphics/testGraphics.C
Original file line number Diff line number Diff line change
Expand Up @@ -132,14 +132,29 @@ int test_json(TCanvas* c1, const std::string& macroName, const std::string& buil
std::string ref_filename = "./json_ref/" + macroName + ".json";
std::string jsonFilePath = builddir + "/json_pro/" + macroName + "_pro.json";

// Save generated Json file
std::ofstream jsonFile(jsonFilePath);
if (jsonFile.is_open()) {
jsonFile << jsonOutput.Data();
jsonFile.close();
FileStat_t fstat;
if (1 == gSystem->GetPathInfo(ref_filename.c_str(), fstat)) {
std::cout << "Reference JSON file not found. Saving generated JSON file as reference." << std::endl;
// Save the generated JSON file as reference
std::ofstream jsonFile(ref_filename);
if (jsonFile.is_open()) {
jsonFile << jsonOutput.Data();
jsonFile.close();
return 1;
} else {
std::cerr << "Error: Unable to open file for writing: " << ref_filename << std::endl;
return 1;
}
} else {
std::cerr << "Error: Unable to open file for writing" << std::endl;
return 1;
// Save the generated JSON file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this part:it would simply write confusing output disguised as references.

std::ofstream jsonFile(jsonFilePath);
if (jsonFile.is_open()) {
jsonFile << jsonOutput.Data();
jsonFile.close();
} else {
std::cerr << "Error: Unable to open file for writing: " << jsonFilePath << std::endl;
return 1;
}
}

// Compare the created JSON to the reference JSON
Expand Down