-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows: Fix declaration for C99 and re-enable Gnu.C test. #174
base: master
Are you sure you want to change the base?
Conversation
This reverts commit 5947e13.
And it's still failing... |
Hopefully no longer. |
And what about the other platforms? |
The test is for GNU keywords, having -std=gnu++14 -std=gnu++1z is enough as they test the same mechanism. If someone feels it is really necessary, then it would probably be best to have a directory devoted to C++11 tests that are not activated on Windows rather than allowing failure all over. |
OK, thanks for the explanation @marsupial. If @vgvassilev confirm (and agrees), and if it fixes the test, then it is would be fine with me |
Updated again to work-around the Windows issue without dropping it entirely. |
Looks good to me. |
@phsft-bot build |
The test was failing for a reason that likely shouldn't be ignored.
This reverts commit 5947e13.