Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

base showOnlyFailingIfMoreElementsThan on expected elements #1102

Closed
robstoll opened this issue Mar 2, 2022 · 0 comments · Fixed by #1119
Closed

base showOnlyFailingIfMoreElementsThan on expected elements #1102

robstoll opened this issue Mar 2, 2022 · 0 comments · Fixed by #1119
Assignees
Milestone

Comments

@robstoll
Copy link
Owner

robstoll commented Mar 2, 2022

Platform (all, jvm, js): all
Extension (none, kotlin 1.3): none

Code related feature

in v0.17.0 we have added the report option showOnlyFailingIfMoreElementsThan for toContain.inOrder.onl
Currently, the default behaviour showOnlyFailingIfMoreElementsThan(10) is based on the number of elements in the IterableLike. It is likely that the number of expected elements is more or less the same as the actual number but it does not need to be. It would be better if we rename it to showOnlyFailingIfMoreExpectedElementsThan (deprecate the current and remove in 0.19.0).

This goes hand in hand with #1100 and should be addressed also for #1094

@robstoll robstoll added this to the 0.18.0 milestone Mar 2, 2022
@robstoll robstoll self-assigned this Mar 2, 2022
@robstoll robstoll linked a pull request Apr 7, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant