Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more logs. #74

Open
riga opened this issue Aug 5, 2019 · 2 comments
Open

Add more logs. #74

riga opened this issue Aug 5, 2019 · 2 comments

Comments

@riga
Copy link
Owner

riga commented Aug 5, 2019

Way more logs are required to get a sense of what is happening in the background if required. Therefore, most of the logs might have DEBUG level, but certainly some should also have INFO and above.

@riga riga self-assigned this Aug 5, 2019
@riga riga added this to the v0.1 milestone Aug 5, 2019
@riga riga modified the milestones: v0.1, v0.2 Dec 9, 2020
@tgy
Copy link
Contributor

tgy commented Aug 25, 2023

Have you considered using loguru? Makes logging quite straightforward

@riga
Copy link
Owner Author

riga commented Aug 26, 2023

Looks good! However, so far I've been hesitating to depend too much on other libraries in the law core for two reasons:

  • For most submission systems we use, we have to send all our software with the jobs (not with particular every job, but we upload our bundled software first to a common location where jobs can pick it up). At least for us, this is quite some motivation to keep the dependencies as streamlined as possible.
  • The sandboxing mechanism (for tasks to switch into bash envs, venvs, docker and singularity containers) is based on the assumption that python, law and its dependencies are available in the sandbox env. This is easy to achieve for bash / venv sandboxes, but for containers this is rarely the case. Or rather: one can't force people to only use containers where law is available. Therefore, a forwarding is in place which places law and its deps into a single directory (via symlinks), and then bind mounts it into the container env. This is not particularly trivial.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants