Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix rhelemeter template validation #557

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Fix rhelemeter template validation #557

merged 1 commit into from
Jul 27, 2023

Conversation

vprashar2929
Copy link
Contributor

Currently, the CI doesn't validate rhelemeter template deployement's correctly. After the PR we require RHELEMETER_EXTERNAL_MTLS_CRT , RHELEMETER_EXTERNAL_MTLS_CA, and RHELEMETER_EXTERNAL_MTLS_KEY to be passed as parameters which are used by rhelemeter.

This PR:

  • Updates launch and CI script to pass the value of these parameters when deploying rhelemeter template.
  • Use the dummy generated certs for rhelemeter deployment to go smoothly on CI.

@philipgough philipgough merged commit 3f8e75b into rhobs:main Jul 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipgough philipgough philipgough approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vprashar2929 @philipgough