Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include nmos-multi-node? #26

Open
garethsb opened this issue Oct 24, 2023 · 2 comments
Open

Include nmos-multi-node? #26

garethsb opened this issue Oct 24, 2023 · 2 comments

Comments

@garethsb
Copy link
Collaborator

Would be nice to investigate how much baggage including https://github.com/garethsb/nmos-cpp-examples/tree/main/nmos-multi-node would add to the container.

@rhastie
Copy link
Owner

rhastie commented Oct 24, 2023

We can potentially add it by extending the "RUN_NODE" functionality in the entrypoint.sh script. It will however increase the container size quite considerably (at least double its size) as we don't currently install or use Python 3 in the runtime container. We might consider moving from Ubuntu as the runtime container base to the python-slim base which is built from Debian. If we do I would feel more comfortable moving the entire Dockerfile to Debian

@garethsb
Copy link
Collaborator Author

Yeah that was my concern... maybe it's an extra layer / different tag, or maybe this is a silly idea 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants