Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use one base class for plain_coap and coap #86

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Cyber1000
Copy link
Contributor

@Cyber1000 Cyber1000 commented May 8, 2021

Since plain_coap has some similarities to coap (except the AES-encryption) I now use a common base between these two. That will also reduce the changes involved moving to another coap-libary (for example aiocoap) in the near future.

Tested with coap, need someone testing this with plain_coap

Depends on #85 (including commits from there), so should be merged afterwards

@Cyber1000
Copy link
Contributor Author

Cyber1000 commented May 8, 2021

To just see changes from this PR, have a look at Cyber1000/py-air-control@master...Cyber1000:coap
(sorry github doesn't provide dependant PRs)

@rgerganov
Copy link
Owner

Thanks, I have merged #85, please rebase.

@Cyber1000
Copy link
Contributor Author

rebased and tested (with coap)

@Cyber1000 Cyber1000 mentioned this pull request May 9, 2021
@rgerganov
Copy link
Owner

Thanks! I wish someone can confirm if this works with plain coap before merging.

@Cyber1000
Copy link
Contributor Author

Cyber1000 commented May 12, 2021

Hoping this too, I also have added a todo, cause I found something I didn't need in coap and don't think I'll need it in plain_coap, but can't verify it myself.
I'll go on with my changes (in further PRs), hoping that meanwhile someone can test this.

todo

@Cyber1000 Cyber1000 mentioned this pull request May 14, 2021
2 tasks
@rgerganov
Copy link
Owner

@shexbeer Could you please test this PR with your device? We want to make sure this change won't break the support for plain_coap. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants