Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request : Icon and timers #50

Open
Macumbafeh opened this issue Dec 7, 2021 · 8 comments
Open

Feature request : Icon and timers #50

Macumbafeh opened this issue Dec 7, 2021 · 8 comments

Comments

@Macumbafeh
Copy link

Macumbafeh commented Dec 7, 2021

Hello !

Me again :D, is it possible to add an option to have bars display on timers, or icons only? Like something in the GUI we can check for it.

Like that
image

This is the version i modified for the CC Tracker.
Also do you mind if i share my version of NugRunning (CCTracker)?

I don't know if you can read when an issue is closed and i replied on it.
I saw some spellID wasn't correct when i tested all the CC.

Thanks a lot for this smart addon !

@Macumbafeh
Copy link
Author

How it looks with spell names.

image

If you want to talk more this is my discord tag : Macumba#4263

@d87
Copy link
Member

d87 commented Dec 9, 2021

I'd rather you make it into a mod/plugin form. Attached is the example of config mod.

NugRunningUserConfig.zip (btw don't mind the comment documentation in there, it's ancient and outdated in parts)
Except in your case you should add this to reset default config first

NugRunningConfig.spells = {}
NugRunningConfig.nameplates = {}
NugRunningConfig.cooldowns = {}
NugRunningConfig.itemcooldowns = {}
NugRunningConfig.activations = {}
NugRunningConfig.event_timers = {}
NugRunningConfig.totems = {}
NugRunningConfig.casts = {}

Timers are similarly skinnable, just hook the default frame construction functions with your changes
https://github.com/rgd87/NugRunning/blob/master/frame.lua#L486
or like this
https://git.tukui.org/Azilroka/AddOnSkins/-/blob/9ea0dd6404cf8ff9df929c2d5b1e32ed4ab69737/Skins/NugRunning.lua
idk which way would be better.
Regarding adding icon mode myself to normal nugrunning, I thought about it and that would be going into WA territory even more, which is futile. It looks alright for your CC purposes tho.

@d87
Copy link
Member

d87 commented Dec 9, 2021

Also with this whole thing there's still an issue that it NEEDS visible nameplates to show correct time, which makes it no better than any other nameplate addons

@Macumbafeh
Copy link
Author

Thanks i'll look into it deeper !

@Macumbafeh
Copy link
Author

Macumbafeh commented Dec 9, 2021

Also with this whole thing there's still an issue that it NEEDS visible nameplates to show correct time, which makes it no better than any other nameplate addons

I tried to disable nameplates and it seems to works also.
You have some bad timers only if you are too far, or the name of the unit disappear

@Macumbafeh
Copy link
Author

Macumbafeh commented Dec 9, 2021

So we did it with a friend (he did it exactly x)), we added a toggle button to swap between bars to icons.
image
image
image

We got it.

@Macumbafeh
Copy link
Author

Macumbafeh commented Dec 11, 2021

The addon is starting to get what i want.
@d87
The last thing i wanted to do is to rename the addon because it doesn't do what NugRunning is suppose to do anymore, i just want to know if i can do it or not.
I understand if you don't want, and this modified addon will be always yours.
I want to rename something like NugRunning_CCTracker

@d87
Copy link
Member

d87 commented Dec 12, 2021

If you made it into a plugin then you can release it I guess, if not then I don't want any cloned alternative versions floating around.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants