Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ggplot gallery: slope graph #75

Open
OskaratOmni opened this issue Jan 12, 2024 · 4 comments
Open

ggplot gallery: slope graph #75

OskaratOmni opened this issue Jan 12, 2024 · 4 comments
Assignees
Labels
documentation Improvements or additions to documentation

Comments

@OskaratOmni
Copy link
Collaborator

Definitely like the labels next to the points instead of in a legend.

This looks good but make colors accessible

@tvroylandt tvroylandt added the documentation Improvements or additions to documentation label Jan 17, 2024
@dgkeyes dgkeyes self-assigned this Jan 17, 2024
@dgkeyes
Copy link
Member

dgkeyes commented Jan 17, 2024

I would typically make this accessible and more useful by making all lines gray except for one. Is this what you want me to do?

@OskaratOmni
Copy link
Collaborator Author

Hey David, I checked with the data viz reviewer on this one and this is what they said:

  • Yeah, making sure that there's enough contrast between the text color and background color of the circles. So the white on orange and white on the light minty green don't have enough contrast to pass the test.

@OskaratOmni
Copy link
Collaborator Author

David how about this:

  • keep the top two groups as they are - so E and B
  • make the rest of the groups an OMNI grey
  • add a title that that is of the approx form ~"Group B decreased from 2022 to 23 while Group E increased" - with 'Group B decreased' and "Group E increased" color coded to match their corresponding circles and lines in the figure?

@dgkeyes
Copy link
Member

dgkeyes commented Jan 31, 2024

How's this?

image

One thing I had to do was make the title text a slightly lighter shade of gray. I think this is a change we should make globally in cases where we want to add color coding for groups in the title. With the default gray in the title, it's hard to see the difference in the colors that represent Groups B and E.

image

Let me know what you think.

@dgkeyes dgkeyes changed the title ggplot gallery: slope graph ggplot gallery: slope graph Apr 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants