Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transit tests #8

Open
awb99 opened this issue Jun 12, 2021 · 3 comments
Open

transit tests #8

awb99 opened this issue Jun 12, 2021 · 3 comments

Comments

@awb99
Copy link

awb99 commented Jun 12, 2021

transit tests are commented out.

should your library be used? or is it irrelevant due to clojure having tagged literals?

@whilo
Copy link
Member

whilo commented Jun 13, 2021

It should be used, but the transit Clojure dependency at some point made it impossible to rebind the map handler, which broke transit support. cognitect/transit-java#31 Unfortunately this is not been resolved yet, but I would be happy to provide help to solve the issue if you need transit support.

@awb99
Copy link
Author

awb99 commented Jul 5, 2021

I think it is very important to have a widely used library that implements additional serialization or edn and transit.
I typically miss datetime and record serialization.
I added them to my web sceleton fraework (which is atop of shadow-cljs and sente):
https://github.com/pink-gorilla/webly/tree/master/src/webly/encoding

But really this is a much broader issue. I think for datahike this is also relevant.

@whilo
Copy link
Member

whilo commented Jul 5, 2021

So you would like to see a serialization library that abstracts over multiple backends and provides additional types such as datetime? That makes sense, although it would be good if we had a serialization format that would work well in general. Feel free to list your requirements or come to our discord channel and we can discuss it there. It is not at the top of our agenda, but we currently also think about extensions, in particular using CBOR to generalize beyond Clojure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants