Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specify container of migrate pod to exec in #19

Closed
LittleFox94 opened this issue Aug 13, 2021 · 4 comments
Closed

Specify container of migrate pod to exec in #19

LittleFox94 opened this issue Aug 13, 2021 · 4 comments

Comments

@LittleFox94
Copy link

When using this on my cluster, it crashed at one point because the migration pod additional containers from linkerd. Besides allowing to add annotations to the migration pod (#18), it would probably be good to specify the container to exec rsync in.

Error was the "you have to specify a container" one, which happens when doing a kubectl exec $pod on a pod with multiple containers without specifying the target container. I sadly don't have any logs saved ._.

I wrote two issues because it's two different problems, but I think this here is the root cause to fix in my setup, while the other (#18) might be important for other setups.

@laverya
Copy link
Member

laverya commented Aug 13, 2021

I think this is probably from where we're tailing the logs of the migration pod - easy enough to fix!

laverya added a commit that referenced this issue Aug 13, 2021
this way if additional containers are injected at runtime there is not an error

see #19
@laverya
Copy link
Member

laverya commented Aug 13, 2021

fix merged.

@LittleFox94
Copy link
Author

oh that was fast, nice job :)

and thank you for this tool, did some of my PVCs by hand some months ago but procrastinated the others for quite some time now ... x)

@laverya
Copy link
Member

laverya commented Aug 13, 2021

@laverya laverya closed this as completed Aug 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants