Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CN-Exec] Add convert_from_cn_map #581

Merged
merged 1 commit into from
Sep 24, 2024
Merged

[CN-Exec] Add convert_from_cn_map #581

merged 1 commit into from
Sep 24, 2024

Conversation

ZippeyKeys12
Copy link
Collaborator

You can't assign directly to an array, so it has to be a statement.
This means there's special-casing in cn_internal_to_ail.ml

@ZippeyKeys12
[CN-Exec] Add convert_from_cn_map
95ee9bb 
And special logic in `cn_internal_to_ail.ml`
@ZippeyKeys12 ZippeyKeys12 self-assigned this Sep 18, 2024
rbanerjee20
rbanerjee20 approved these changes Sep 24, 2024
View reviewed changes
Copy link
Contributor

@rbanerjee20 rbanerjee20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ZippeyKeys12 ZippeyKeys12 merged commit 2c4e255 into rems-project:master Sep 24, 2024
2 checks passed
@ZippeyKeys12 ZippeyKeys12 deleted the cn-exec-convert-from-cn-map branch September 24, 2024 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbanerjee20 rbanerjee20 rbanerjee20 approved these changes

Assignees

@ZippeyKeys12 ZippeyKeys12

Labels
cn
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZippeyKeys12 @rbanerjee20