Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

process for moving default settings from scenario_config.csv to main.gms #1461

Open
0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q opened this issue Nov 14, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member

I am trying to transplant settings from the DeepEl scenario config to another project and was checking where they differ from the current default. One set of differences raised the question of defaults being defined in scenario_config.csv or main.gms.

read_delim(file = 'config/scenario_config.csv', delim = ';', comment = '#',
           show_col_types = FALSE) %>% 
    mutate(across(-'title', as.character)) %>% 
    filter('testOneRegi-Base' != title) %>%   # debug run (probably outdated)
    pivot_longer(-'title') %>% 
    group_by(name) %>% 
    filter(1 == length(unique(value)),
           !all(is.na(value))) %>%   # NAs are explicit defaults
    pivot_wider()
# A tibble: 47 × 3                                                                                                                                
   title                     cm_altFeEmiFac     water
   <chr>                     <chr>              <chr>
 1 SSP2EU-NPi-calibrate      EUR_regi, NEU_regi heat 
 2 SSP2EU-Base               EUR_regi, NEU_regi heat 
 3 SSP2EU-NDC                EUR_regi, NEU_regi heat 
 4 SSP2EU-NPi                EUR_regi, NEU_regi heat 
 5 SSP2EU-PkBudg500          EUR_regi, NEU_regi heat 
 6 SSP2EU-PkBudg650          EUR_regi, NEU_regi heat 
 7 SSP2EU-PkBudg1050         EUR_regi, NEU_regi heat 
 8 SSP2EU-EU21-NPi-calibrate EUR_regi, NEU_regi heat 
 9 SSP2EU-EU21-Base          EUR_regi, NEU_regi heat 
10 SSP2EU-EU21-NDC           EUR_regi, NEU_regi heat 

cm_altFeEmiFac is almost three years old (#311), while water is positively antediluvian.

  1. Should those two settings not be moved to main.gms
  2. Can we have a process that checks this kind of stuff regularly?
@LaviniaBaumstark
Copy link
Member

1.) I have no idea about cm_altFeEmiFac but would assume that we should adjust it in main.gms, abuóut water there was a discussion and if I remember correctly, we could not agree on adjusting teh default in the main.gmsBut now I would say: that is de-facto our default, let's transfer it.
2.) do you mean as part of a validation process or a test part of the AMTs?

@0UmfHxcvx5J7JoaOhFSs5mncnisTJJ6q
Copy link
Member Author

AMTs run too often and nobody looks at the logs, unless they fail. Not sure if they should fail on this, though.
I think we only need a script to check this and need to remember to run it whenever scenario_config.csv is modified. Could go into Makefile:check, which should be run before every commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants