Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async upload providers #465

Open
ginkoid opened this issue Aug 7, 2020 · 0 comments
Open

Async upload providers #465

ginkoid opened this issue Aug 7, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@ginkoid
Copy link
Member

ginkoid commented Aug 7, 2020

At the moment, all upload providers are loaded synchronously with require():

// FIXME: use async loading
// eslint-disable-next-line @typescript-eslint/no-var-requires
const ProviderClass = require(path.join('../providers', name)).default

We should use import() instead, such as in email providers:

const { default: Provider } = await import(path.join('../providers', emailConfig.provider.name)) as { default: ProviderConstructor }

@ginkoid ginkoid added the enhancement New feature or request label Aug 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant