Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

it seems that node_modules is now required in order to run #12

Open
thoraxe opened this issue Jun 8, 2021 · 0 comments
Open

it seems that node_modules is now required in order to run #12

thoraxe opened this issue Jun 8, 2021 · 0 comments
Assignees

Comments

@thoraxe
Copy link
Contributor

thoraxe commented Jun 8, 2021

nginx logs:
2021/06/08 20:03:59 [error] 24#24: *2 open() "/usr/share/nginx/html/node_modules/protobufjs/dist/protobuf.js" failed (2: No such file or directory), client: 10.0.2.100, server: localhost, request: "GET /node_modules/protobufjs/dist/protobuf.js HTTP/1.1", host: "localhost:8080", referrer: "http://localhost:8080/index.html"

It looks like we are now dependent on node.js to serve, or at least for the node_modules to be committed to the repo? This is probably not good.

Did you mean for this to be the case, @Jared-Sprague ?

@thoraxe thoraxe assigned thoraxe and Jared-Sprague and unassigned thoraxe Jun 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants