Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove copy of podman CLI implementation and migrate to new API when implemented #44

Open
dgolovin opened this issue Feb 14, 2024 · 6 comments · May be fixed by #182
Open

Remove copy of podman CLI implementation and migrate to new API when implemented #44

dgolovin opened this issue Feb 14, 2024 · 6 comments · May be fixed by #182
Assignees

Comments

@dgolovin
Copy link
Collaborator

Current implementation is copied form podman extension and should be removed when podman desktop has new API to call podman commands containers/podman-desktop#5990.

@dgolovin
Copy link
Collaborator Author

dgolovin commented Jun 28, 2024

@benoitf where package with API definition should be placed. Should it be done the same way as for @podman-destop/api?

@benoitf
Copy link
Collaborator

benoitf commented Jun 28, 2024

yes probably we should have it part of the podman extension and published on each release

probably another package or refactor the podman extension to have multiple folders (not sure it'll work fine to automatically load the extension using that way)

@dgolovin
Copy link
Collaborator Author

@benoitf Would implementing it as podman module in the extension-api similar to docker.exec work?

Here is an implementation https://github.com/containers/podman-desktop/compare/main...dgolovin:i5990?expand=1

@benoitf
Copy link
Collaborator

benoitf commented Jul 11, 2024

@dgolovin there should be no podman module ( no changes in the extension loader file)

it's the other extensions that can get the extension object from get extensions(extensionName) and then use the .exports object from there

@dgolovin
Copy link
Collaborator Author

there should be no podman module ( no changes in the extension loader file)

@benoitf I can do it in similar fashion as #7961, but that will:

  • produce additional package in packages folder
  • package will be published not matter if there is no changes in API
  • it still would be used in extension only

For external contributions that would be required, podman extension is built-in and always present why not expose it in @podamn-desktop/api?

@benoitf
Copy link
Collaborator

benoitf commented Jul 11, 2024

because the podman extension might not always be a default extension. Also users can disable the extension.

And it should always be within extensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants