support the advisory search REST API

[ktdreyer]

The /errata endpoint will allow us to search for advisories. Like: /errata?errata_filter[filter_params][some_field]=some_value

We should implement a "filter()" method (on ErrataConnector?) that lets us pass in parameters here. See tree/examples/curl/filter.sh in errata-rails.git as an example.

[yazug]

I like this idea

def ErrataConnector::filter(self, filter_category, kwargs**): return json

filter_category => would be 'errata', 'releases', 'products'
then a follow up might be to encode either in connector or another place some convenience searches, for common sets of work to it would be like

def ErrataConnector::filter_advisories(release_name_or_id, state): return json
def ErrataConnector::filter_releases(release_name_or_id): return json

common ones I've seen are release name/id, product name/id, state (new files, qe, rel_prep, in_push, closed drop, shipped live), closed flag, advisory type

then usage could be either

ErrataConnector::filter('releases', is_active=True, enabled=True, name=)

or helper for same
def filter_releases(self, name_or_id, is_active=True, enabled=True): return json
def filter('errata', show_type_RHBA=True, show_type_RHEA=True, show_type_RHSA=True, show_state_DROPPED_NO_SHIP=False,release=[<release_id>, release_id_2>], show_state=[NEW_FILES, QE, REL_PREP, PUSH_READY, IN_PUSH]): return json

or something like that, and either filter or the helper may have to help rotate logic because in kwargs single argument name but api seems to allow duplicate, so might have to have small acceptances of rotations. But keep it thin in logic in the filter() function and write other helpers to expose more of the nuances of common usage patterns

[yazug]

example of another filter
'/api/v1/releases?filter[is_active]=true&filter[enabled]=true&filter[name]={}'
endpoint = '/api/v1/releases'
kwargs={is_active:True, enabled:True, name:}

and one mentioned first would be
endpoint='/errata
kwargs= {some_field:}

[yazug]

one thing I found was errata endpoint filter will need some heavy helpers to make it work cleanly ... there are several anomalies in that search function, but I did find the releases filter option usable and pretty clean. the releases filter option or the product map would be required if you are going from a release name to a release id when trying to search.

[ktdreyer]

I would like to keep the basic filter method lightweight so we only make a single HTTP request if possible.

[simonbaird]

FYI there's a new endpoint you can use for this coming soon, probably in ET 4.4, early December.

Details
Code

[ktdreyer]

Thanks @simonbaird , we should totally use that instead.

api guide look for /api/v1/erratum/search