Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release v1.11 causes rustc compiler to fail with inline assembly #342

Open
jonathanpwang opened this issue Nov 4, 2023 · 1 comment
Open

Release v1.11 causes rustc compiler to fail with inline assembly #342

jonathanpwang opened this issue Nov 4, 2023 · 1 comment

Comments

@jonathanpwang
Copy link

See axiom-crypto/snark-verifier#43 for a cargo bisect.

In short, for very unknown reasons, the change from ruint v1.10 -> v1.11 has caused something to change in how the recent rustc compilers / LLVM optimizes raw assembly code blocks in https://github.com/axiom-crypto/halo2curves/blob/main/src/bn256/assembly.rs

I have no idea what could have caused this, so would be interested in learning.
@prestwich
Copy link
Collaborator

FFR here is the diff between 1.10.1 and 1.11.0

v1.10.1...v1.11.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@prestwich @jonathanpwang