Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] - Image batches failing #67

Open
RangerFrank opened this issue Apr 9, 2024 · 5 comments
Open

[BUG] - Image batches failing #67

RangerFrank opened this issue Apr 9, 2024 · 5 comments
Labels
bug Something isn't working

Comments

@RangerFrank
Copy link

Description

Image batches failing due to random seed changing from -1 to the last generated seed randomly, messing up the rest of the queue and throwing a ksampler error indicating it was fed a negative integer instead of a seed value.

Reproduction steps

Queue 6+ images on random seed, by about the 5th generation the seed will change from -1 to a fixed seed.

Image file

No response

@RangerFrank RangerFrank added the bug Something isn't working label Apr 9, 2024
@receyuki
Copy link
Owner

receyuki commented Apr 9, 2024

I can't reproduce this issue. Could you please post your workflow here and tell me how you operated it?

@RangerFrank
Copy link
Author

After further testing it occurs when I change the positive prompt while there are images queued, and then queue more. The first image queued after changing the prompt will cause SD Param Gen to fix the seed to the last image in queue.

@receyuki
Copy link
Owner

The bad news is I still can't trigger this bug.
When the error occurs, does the third button under Param Gen display the correct number?
Have you tried deleting the node, refreshing the page, and re-adding this node?

@RangerFrank
Copy link
Author

I have tried readding and rebuilding the node. I'm starting to think it might be a parsing issue with Efficiency Nodes KSampler

@RangerFrank
Copy link
Author

RangerFrank commented Apr 20, 2024

The problem occurs when queued image settings change. If you keep the seed fixed you can queue images with different conditioning, loras, etc without issue. If you randomise the seed and queue a number of images, changing any of the settings and queuing 2 or more will cause the seed to become fixed when the first different generation hits the ksampler and following queued generations will fail.

I've found a workaround for this by using the Global Seed node from Inspire Pack, this allows for seed generation before queueing instead of after, fixing the issue. It might be good to have some of that functionality built directly into the parameter generator node.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants