Prepare for 0.2.2 release. Update names of Pastel.parse and Pastel.apply to be prefixed by unstable to reflect their currently experimental nature #208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ply to be prefixed by unstable to reflect their currently experimental nature
facebook-github-bot
added
the
CLA Signed
kyldvs
approved these changes
Nov 5, 2019
src/pastel/Pastel.rei
Outdated
| @@ -117,6 +117,10 @@ let createElement: | |||
| ) => | |||
| string; | |||
|
|
|||
| /** Pastel.style exposes a way to examine and manipulate the styles of existing text in | |||
There was a problem hiding this comment.
Fix comment formatting please.
/**
* content
*/
src/pastel/Pastel.rei
Outdated
|
|
||
| let parse: string => list((style, string)); | ||
| let apply: list((style, string)) => string; | ||
| /** These functions are considered unstable and are subject to change |
There was a problem hiding this comment.
Fix comment formatting please.
/**
* content
*/
There was a problem hiding this comment.
@bandersongit is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
|
@bandersongit merged this pull request in 0eea180. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to release a new version of Pastel for JSOO compatibility (#207). This should ideally have been done when the usage of Str was removed in favor of Re