Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep only command-line related functions in swiftlint module #5806

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

SimplyDanny
Copy link
Collaborator

Swift 6 doesn't allow importing executable targets. So we need to move testable logic into a framework.

@SwiftLintBot
Copy link

SwiftLintBot commented Sep 21, 2024

1 Warning
⚠️ If this is a user-facing change, please include a CHANGELOG entry to credit yourself!
You can find it at CHANGELOG.md.
17 Messages
📖 Linting Aerial with this PR took 0.92s vs 0.95s on main (3% faster)
📖 Linting Alamofire with this PR took 1.28s vs 1.28s on main (0% slower)
📖 Linting Brave with this PR took 7.49s vs 7.46s on main (0% slower)
📖 Linting DuckDuckGo with this PR took 5.08s vs 5.09s on main (0% faster)
📖 Linting Firefox with this PR took 11.12s vs 11.03s on main (0% slower)
📖 Linting Kickstarter with this PR took 10.1s vs 10.09s on main (0% slower)
📖 Linting Moya with this PR took 0.53s vs 0.53s on main (0% slower)
📖 Linting NetNewsWire with this PR took 2.56s vs 2.55s on main (0% slower)
📖 Linting Nimble with this PR took 0.77s vs 0.77s on main (0% slower)
📖 Linting PocketCasts with this PR took 8.7s vs 8.66s on main (0% slower)
📖 Linting Quick with this PR took 0.44s vs 0.43s on main (2% slower)
📖 Linting Realm with this PR took 4.73s vs 4.7s on main (0% slower)
📖 Linting Sourcery with this PR took 2.37s vs 2.34s on main (1% slower)
📖 Linting Swift with this PR took 4.63s vs 4.59s on main (0% slower)
📖 Linting VLC with this PR took 1.26s vs 1.26s on main (0% slower)
📖 Linting Wire with this PR took 18.35s vs 18.21s on main (0% slower)
📖 Linting WordPress with this PR took 11.88s vs 11.79s on main (0% slower)

Here's an example of your CHANGELOG entry:

* Keep only command-line related functions in `swiftlint` module.  
  [SimplyDanny](https://github.com/SimplyDanny)
  [#issue_number](https://github.com/realm/SwiftLint/issues/issue_number)

note: There are two invisible spaces after the entry's text.

Generated by 🚫 Danger

Swift 6 doesn't allow importing executable targets. So we need to
move testable logic into a framework.
Copy link
Collaborator

@mildm8nnered mildm8nnered left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, and compiles and tests fine on my outdated Xcode 15.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants