-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update text inputs to use focus/blur instead of on-change #141
Comments
Maybe this could be a knob that defaults to on-blur? Not sure I have a really compelling usecase for updating on each keypress, but it seems useful to have the choice. (Of course I still have the ability to implement the Numeric fields already behave like this, the difference might be causing some confusion (#143). |
Yeah, having an option might be better. For desktop browsers, on-change event doesn't tend to cause any issues, however I have seen this become a problem on mobile before. |
Additionally, the updating of the state is generally the responsibility of us rather than the lib (at least in React land). This gives the developer options to either update on whatever event handler they choose, or not update at all and use refs to grab the values of inputs when generating a payload. |
Currently, inputs recompute on each key press, it would be better to update inputs once when the user finishes typing.
The text was updated successfully, but these errors were encountered: