Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ScopeResolution: unnecessary execution of code #1274

Open
skrynski opened this issue Apr 1, 2024 · 0 comments
Open

ScopeResolution: unnecessary execution of code #1274

skrynski opened this issue Apr 1, 2024 · 0 comments
Labels
bug good first issue pir to be solved in the compiler, the PIR, the optimizer (/compiler)

Comments

@skrynski
Copy link
Collaborator

skrynski commented Apr 1, 2024

The code here will run on every iteration of this pass. Even if it does not change the 'changed' flag , the method fromContext should not be invoked more than is required.

rir/rir/src/compiler/opt/scope_resolution.cpp

Line 317 in 0c2896f

force->type.fromContext(cls->context(), a->pos,

@skrynski skrynski added bug good first issue pir to be solved in the compiler, the PIR, the optimizer (/compiler) labels Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue pir to be solved in the compiler, the PIR, the optimizer (/compiler)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@skrynski