Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On changing colorScheme of BladeProvider, it doesn't re-render all children again. #2269

Open
jaywalker21 opened this issue Jun 25, 2024 · 0 comments
Assignees
Labels
P1 Kinda Important

Comments

@jaywalker21
Copy link

jaywalker21 commented Jun 25, 2024

  • If we use a state variable to maintain the colorScheme and update it dynamically, then the BladeProvider doesn't respond to it.
  • One hacky way to achieve the same is by passing a key which includes the aforementioned colorScheme. The same has been done in the following line used in storybook.
    key={`${colorScheme}-${borderBase}-${selectedColor}-${selectedPreBuiltTheme}`}
  • While, this is not a blocker, it does seem to be less intuitive for any end user.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 Kinda Important
Projects
None yet
Development

No branches or pull requests

4 participants