Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

On-site feedback (2022-02) #156

Closed
2 of 7 tasks
ralfbiedert opened this issue Feb 23, 2022 · 0 comments
Closed
2 of 7 tasks

On-site feedback (2022-02) #156

ralfbiedert opened this issue Feb 23, 2022 · 0 comments
Labels
bug Fake news or not working code. help-wanted Help especially wanted. suggested-via-site Feedback given directly on the site.

Comments

@ralfbiedert
Copy link
Owner

ralfbiedert commented Feb 23, 2022

  • type-aliases-and-casts - Maybe mention from/into/try_into in this section or at least link to a section with those here. They are not mentioned because the "upper" sections are only language (in contrast to API) related, the section Type Conversions lists all of them and more. Added a link.
  • generics-constraints - The S where u8: R example could use some explanation what u8: R means, does it mean u8 needs to implement a trait R with a parameter T? Yes, it does mean that. I'm happy to clarify the samples but they still have to fit a single line each. PR proposals welcome.
  • common-operators - It might be useful to list the operators anyway along with the traits used to implement them. Yes, see Bit wise operations missing? #151!
  • common-operators - It might make sense to have a section with the operators as well as the checked, saturating and wrapped versions of the operations. Similar to above; although I'm not sure how the checked, ... would differ explanation-wise. I mean, yes, they obviously differ, but IMO the name already explains exactly what happens linguistically. If someone has a specific idea feel free to post here or in Bit wise operations missing? #151.
  • project-anatomy - This is missing the multi-binary forms src/bin/<name>.rs [TIL]
  • project-anatomy - It might be useful to mention some or all of rust-toolchain.toml, deny.toml (from cargo-deny), tarpaulin.toml (from cargo-tarpaulin) in this list too After some back and forth I don't want to document 3rd party tools anymore since it gets out of hand. That said, rust-toolchain.toml is a good idea!
  • closures-in-apis - Maybe in this section function pointer (lower case fn) types should also be mentioned? Hm, function pointers might deserve a bit more treatment (esp. their "type-iness" w.r.t. for<'a>), but I think that's unrelated to that section, which is about the "inheritance" / design-trade-off between the different traits.
@ralfbiedert ralfbiedert added bug Fake news or not working code. help-wanted Help especially wanted. suggested-via-site Feedback given directly on the site. labels Feb 23, 2022
ralfbiedert added a commit that referenced this issue Feb 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fake news or not working code. help-wanted Help especially wanted. suggested-via-site Feedback given directly on the site.
Projects
None yet
Development

No branches or pull requests

1 participant