From e7198f4b1ab4b45bc3c5e145d8e2165abc3ac089 Mon Sep 17 00:00:00 2001 From: Yasuo Honda Date: Tue, 1 Oct 2024 16:16:19 +0900 Subject: [PATCH] Remove redundant `run` methods in `SolidQueue::Processes` This commit removes one of the redundant `run` methods in `SolidQueue::Processes` Here are the warning messages appeared at Rails Nightly CI: https://buildkite.com/rails/rails-nightly/builds/1091#019244bc-9d36-476d-8924-5e2bea4cb728/1173-1176 ``` /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:52: warning: method redefined; discarding old run /usr/local/lib/ruby/gems/3.4.0+0/gems/solid_queue-1.0.0/lib/solid_queue/processes/runnable.rb:44: warning: previous definition of run was here ``` --- lib/solid_queue/processes/runnable.rb | 4 ---- 1 file changed, 4 deletions(-) diff --git a/lib/solid_queue/processes/runnable.rb b/lib/solid_queue/processes/runnable.rb index 2c11cf3d..33b441f6 100644 --- a/lib/solid_queue/processes/runnable.rb +++ b/lib/solid_queue/processes/runnable.rb @@ -41,10 +41,6 @@ def boot end end - def run - raise NotImplementedError - end - def shutting_down? stopped? || (running_as_fork? && supervisor_went_away?) || finished? || !registered? end