Add 'Until' column to contributors index #303
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuay03
force-pushed
the
add-until-column-to-contributors-index
branch
2 times, most recently
from
a30b515
to
8daf9f8
Compare
joshuay03
commented
Aug 24, 2024
| @@ -5,9 +5,8 @@ def test_index | |||
| get :index | |||
| assert_response :success | |||
|
|
|||
| assert_select 'span.listing-total', 'Showing 5 releases' | |||
joshuay03
force-pushed
the
add-until-column-to-contributors-index
branch
2 times, most recently
from
5df299d
to
499e068
Compare
joshuay03
commented
Aug 24, 2024
| @@ -4,34 +4,53 @@ class RepoTest < ActiveSupport::TestCase | |||
| test '#sync_ranks' do | |||
| Repo.new.send(:sync_ranks) | |||
|
|
|||
| {jeremy: 1, david: 2, jose: 3, xavier: 3, vijay: 3}.each do |c, r| | |||
| {jeremy: 1, david: 2, jose: 2, xavier: 4, vijay: 4}.each do |c, r| | |||
There was a problem hiding this comment.
This seems like a bug. Not introduced here cause it can be observed on the official site.
I think it makes more sense that if multiple contributors share a rank the next contributor should be assigned the next rank i.e. this should be:
Suggested change
| {jeremy: 1, david: 2, jose: 2, xavier: 4, vijay: 4}.each do |c, r| | |
| {jeremy: 1, david: 2, jose: 2, xavier: 3, vijay: 3}.each do |c, r| |
joshuay03
force-pushed
the
add-until-column-to-contributors-index
branch
from
499e068
to
dd397c9
Compare
|
Hey, thanks for proposing this. I am not 100% sure I like the idea. Reason is, the spirit to this website is to give credit to people and pay tribute to them with public recognition. It is less about "data". I'd even consider dropping "Since". Let us think about it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #289
QA (with synced Rails repo)
dc/syncworks as expected with a fresh DB