Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop running experiment if stage fails #325

Open
bobkopp opened this issue Mar 22, 2024 · 4 comments
Open

Stop running experiment if stage fails #325

bobkopp opened this issue Mar 22, 2024 · 4 comments
Assignees

Comments

@bobkopp
Copy link
Collaborator

bobkopp commented Mar 22, 2024

No description provided.

@bobkopp
Copy link
Collaborator Author

bobkopp commented Sep 5, 2024

@mturilli Is there a way to specify this when EnTK is invokved?

@andre-merzky
Copy link
Contributor

Hi @bobkopp : the last EnTK release adds a flag to the task description error_is_fatal. That defaults to False, but if set to True it will cause the error to propagate up to the Stage, Pipeline and ultimately the workflow which will then complete. This was merged with this pull request in EnTK.

@bobkopp
Copy link
Collaborator Author

bobkopp commented Sep 6, 2024

@mturilli @andre-merzky could you identify where this could be introduced in runFACTS.py or FACTS.py? Thanks!

@andre-merzky
Copy link
Contributor

@mturilli @andre-merzky could you identify where this could be introduced in runFACTS.py or FACTS.py? Thanks!

EnTK task instances are created in FACTS.py at line 84. Adding t.error_is_fatal somewhere after that line should result in the expected behavior. Please do let me know if the result is not what you expect!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants