Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critically examine existing preprocess/fit/project/postprocess stage breakdown #255

Open
bobkopp opened this issue Oct 30, 2023 · 1 comment

Comments

@bobkopp
Copy link
Collaborator

bobkopp commented Oct 30, 2023

Existing modules generally break down into preprocess/fit/project/postprocess stages, though this is not religiously enforced (e.g., see the facts/* modules). In the FACTS manager, this can be flexibly specified in the pipeline file, and it is not clear that this distinction makes sense to maintain in general.

Most modules can be broken down into:

  • Preparing input data (preprocess and fit stage)
  • Computationally intensive execution (project stage)
  • Localization (postprocess stage)

Though with the exception of the sterodynamics module, localization is done through the application of GRD fingerprints, which in the long run perhaps should be done by a separate module in a separate experiment step.

But, for example, in the fair/temperature module, there is no clear reason why emissions should be imported in the preprocess step and model calibration parameters in the fit step, nor is there a reason to have an empty postprocessing step. In this particular module, the breakdown can be critically examined as preparation for the development of the fair2 module.

@bobkopp
Copy link
Collaborator Author

bobkopp commented Dec 16, 2023

The labels are hard coded in FACTS.py. It is unclear that they need to be.

@bobkopp bobkopp modified the milestones: v1.2, v1.3 Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants