Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth 2 guide updates #2044

Merged
merged 2 commits into from
Sep 6, 2024
Merged

Conversation

MarcialRosales
Copy link
Contributor

@MarcialRosales MarcialRosales commented Sep 4, 2024

Note: Entra/Azure example is still using v1 url for the oauth_provider_url and v2 for the jwks_url. At this time, it is not possible to use v2 also in the oauth_provider_url until rabbitmq/rabbitmq-server#12235 is completed.

I have also noticed that the latest Entra/Azure's user interface differs a bit from the screenshots attached to the example. Once the aforementioned PR is completed, I will update the screenshots on a separate docs PR

@MarcialRosales MarcialRosales changed the title Use only ini-config style over erlang style Use ini-config style over erlang style in oauth2 documentation Sep 4, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 4, 2024

Deploying rabbitmq-website with  Cloudflare Pages  Cloudflare Pages

Latest commit: c139f13
Status: ✅  Deploy successful!
Preview URL: https://84e65307.rabbitmq-website.pages.dev
Branch Preview URL: https://deprecate-erlang-style-in-co.rabbitmq-website.pages.dev

View logs

@MarcialRosales MarcialRosales self-assigned this Sep 4, 2024
@MarcialRosales MarcialRosales force-pushed the deprecate-erlang-style-in-config-files branch from f4222f8 to 7c7d223 Compare September 5, 2024 13:58
@michaelklishin
Copy link
Member

I have fixed the build. @MarcialRosales we should probably do this renaming for the 3.13.x version, too?

@MarcialRosales
Copy link
Contributor Author

@michaelklishin , yes, once I finished doing all the changes in the docs , I apply those changes to 3.13.x too.

@MarcialRosales MarcialRosales force-pushed the deprecate-erlang-style-in-config-files branch from 197e5e7 to 9032d5a Compare September 6, 2024 10:11
@MarcialRosales MarcialRosales marked this pull request as ready for review September 6, 2024 14:00
@MarcialRosales MarcialRosales force-pushed the deprecate-erlang-style-in-config-files branch from 7e044b5 to c94259c Compare September 6, 2024 15:18
@michaelklishin michaelklishin changed the title Use ini-config style over erlang style in oauth2 documentation OAuth 2 guide updates Sep 6, 2024
@michaelklishin michaelklishin merged commit 295767b into main Sep 6, 2024
2 checks passed
@michaelklishin michaelklishin deleted the deprecate-erlang-style-in-config-files branch September 6, 2024 19:26
michaelklishin added a commit that referenced this pull request Sep 6, 2024
Conflicts:
	docs/troubleshooting-oauth2.md
	versioned_docs/version-3.13/troubleshooting-oauth2.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants