From f51a5922a3670dacf69fbcac7702ff67b066261b Mon Sep 17 00:00:00 2001 From: Michael Chirico Date: Wed, 29 Nov 2023 22:01:18 +0800 Subject: [PATCH] Drop obsolete references to R3.5 (#1881) * Drop skip for unsupported R3.5 * Remove conditional eval in vignette too * trailing comma --- tests/testthat/test-expect-known.R | 2 -- vignettes/test-fixtures.Rmd | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/testthat/test-expect-known.R b/tests/testthat/test-expect-known.R index db09d941a..e37e247bb 100644 --- a/tests/testthat/test-expect-known.R +++ b/tests/testthat/test-expect-known.R @@ -105,7 +105,6 @@ test_that("equal_to_ref does not overwrite existing", { }) test_that("serializes to version 2 by default", { - skip_if(getRversion() < "3.5") tmp_rds <- tempfile(fileext = ".rds") on.exit(unlink(tmp_rds)) @@ -118,7 +117,6 @@ test_that("serializes to version 2 by default", { }) test_that("version 3 is possible", { - skip_if(getRversion() < "3.5") tmp_rds <- tempfile(fileext = ".rds") on.exit(unlink(tmp_rds)) diff --git a/vignettes/test-fixtures.Rmd b/vignettes/test-fixtures.Rmd index af4e6e653..37791585e 100644 --- a/vignettes/test-fixtures.Rmd +++ b/vignettes/test-fixtures.Rmd @@ -10,9 +10,7 @@ vignette: > ```{r, include = FALSE} knitr::opts_chunk$set( collapse = TRUE, - comment = "#>", - # Since after is not available prior to 3.5 - eval = getRversion() >= "3.5" + comment = "#>" ) ```