Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] Is scales::pvalue() guaranteed to be kept? #377

Closed
Generalized opened this issue Jan 30, 2023 · 1 comment
Closed

[Question] Is scales::pvalue() guaranteed to be kept? #377

Generalized opened this issue Jan 30, 2023 · 1 comment

Comments

@Generalized
Copy link

This function is extremely useful in clinical reporting, where used alone with the result to format.
I read it is "superseded" now. It would be truly a pity to lose it in future, making one to either write (another) custom function or use other packages. Sure, it's not a complicated piece of code and one can easily write one themselves, but having it "onboard" makes the environment cleaner.
It's said that "These functions are kept for backward compatibility; you should switch to label_pvalue() for new code.". Does "kept" here mean in "this and a maybe few more versions" or forever?

@Generalized Generalized changed the title [Question] Is scales::pvalue() guaranteed to be keept? [Question] Is scales::pvalue() guaranteed to be kept? Jan 30, 2023
@thomasp85
Copy link
Member

In general "Deprecated" means that over the cause of a number of releases it will be removed. Superseded means that we have no plans of removing it but we are not advocating its use since we have found what we think is a better approach.

So, while there are no guarantees in life, we have no plans to remove scales::pvalue() in the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants