Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release ps 1.8.0 #178

Closed
22 tasks done
gaborcsardi opened this issue Sep 12, 2024 · 4 comments
Closed
22 tasks done

Release ps 1.8.0 #178

gaborcsardi opened this issue Sep 12, 2024 · 4 comments

Comments

@gaborcsardi
Copy link
Member

gaborcsardi commented Sep 12, 2024

Prepare for release:

  • git pull
  • Check current CRAN check results
  • Bump required R version in DESCRIPTION to 4.0
  • Polish NEWS
  • urlchecker::url_check()
  • devtools::build_readme()
  • devtools::check(remote = TRUE, manual = TRUE)
  • devtools::check_win_devel()
  • revdepcheck::revdep_check(num_workers = 8)
  • Update cran-comments.md
  • git push
  • Draft blog post
  • Slack link to draft blog in #open-source-comms

Submit to CRAN:

  • usethis::use_version('minor')
  • devtools::submit_cran()
  • Approve email

Wait for CRAN...

  • Accepted 🎉
  • Finish & publish blog post
  • Add link to blog post in pkgdown news menu
  • usethis::use_github_release()
  • usethis::use_dev_version(push = TRUE)
  • Tweet
@barracuda156
Copy link
Contributor

@gaborcsardi I am not sure what is the latest macOS where this is broken now, but FWIW:

/opt/local/bin/gcc-mp-13 -I"/opt/local/Library/Frameworks/R.framework/Resources/include" -DNDEBUG   -isystem/opt/local/include/LegacySupport -I/opt/local/include    -fPIC  -pipe -Os -arch ppc  -c api-macos.c -o api-macos.o
api-macos.c: In function 'ps__fs_info':
api-macos.c:1237:39: error: 'struct statfs' has no member named 'f_fssubtype'
 1237 |     REAL(VECTOR_ELT(res, 14))[i] = sfs.f_fssubtype;
      |                                       ^
api-macos.c:1257:53: error: 'MNT_CPROTECT' undeclared (first use in this function); did you mean 'UNPROTECT'?
 1257 |     LOGICAL(VECTOR_ELT(res, 33))[i] = sfs.f_flags & MNT_CPROTECT;
      |                                                     ^~~~~~~~~~~~
      |                                                     UNPROTECT
api-macos.c:1257:53: note: each undeclared identifier is reported only once for each function it appears in
make: *** [api-macos.o] Error 1

@barracuda156
Copy link
Contributor

barracuda156 commented Sep 13, 2024

UPD. MNT_CPROTECT is available in 10.9+: https://lists.gnu.org/archive/html/monit-general/2017-04/msg00018.html

UPD2. I will handle this, please ignore this message. Once it works, I make a PR.

@barracuda156
Copy link
Contributor

There is also this, with another source file:

arch/macos/disk.c: In function 'ps__disk_io_counters':
arch/macos/disk.c:38:9: warning: 'IORegistryEntryGetParentEntry' reading 128 bytes from a region of size 10 [-Wstringop-overread]
   38 |     if (IORegistryEntryGetParentEntry(disk, kIOServicePlane, &parent)
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/macos/disk.c:38:9: note: referencing argument 2 of type 'const char[128]'
In file included from arch/macos/disk.c:2:
/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:1120:1: note: in a call to function 'IORegistryEntryGetParentEntry'
 1120 | IORegistryEntryGetParentEntry(
      | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/macos/disk.c:45:9: warning: 'IOObjectConformsTo' reading 128 bytes from a region of size 21 [-Wstringop-overread]
   45 |     if (IOObjectConformsTo(parent, "IOBlockStorageDriver")) {
      |         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
arch/macos/disk.c:45:9: note: referencing argument 2 of type 'const char[128]'
/System/Library/Frameworks/IOKit.framework/Headers/IOKitLib.h:256:1: note: in a call to function 'IOObjectConformsTo'
  256 | IOObjectConformsTo(
      | ^~~~~~~~~~~~~~~~~~
/opt/local/bin/gcc-mp-13 -I"/opt/local/Library/Frameworks/R.framework/Resources/include" -DNDEBUG   -isystem/opt/local/include/LegacySupport -I/opt/local/include    -fPIC  -pipe -Os -arch ppc -fobjc-exceptions  -c arch/macos/apps.m -o arch/macos/apps.o
arch/macos/apps.m: In function 'ps__list_apps':
arch/macos/apps.m:40:3: error: 'for' loop initial declarations are only allowed in C99 or C11 mode
   40 |   for (NSUInteger i = 0; i < count; i++) {
      |   ^~~
arch/macos/apps.m:40:3: note: use option '-std=c99', '-std=gnu99', '-std=c11' or '-std=gnu11' to compile your code
make: *** [arch/macos/apps.o] Error 1
ERROR: compilation failed for package ‘ps’

@barracuda156
Copy link
Contributor

This fixes everything: #179
But one warning on CI re ObjC flag usage, I need an advice on that :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants