You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
req_template() supports glue syntax, but loses the composability of request() |> req_url_path_append(). But paths are often also documented with glue-like syntax. For example, the apis.guru api has a /{provider}.json path, where provider is a path parameter (and the OpenAPI spec specifically allows such path parameters).
At first I thought this would need a new function, but in theory req_url_path() and req_url_path_append() could treat named arguments as path parameters, making these equivalent:
It looks like only dots_to_path would need to be updated, and the tests look robust enough that it could be done safely, I think. I could probably whip up a PR if this sounds reasonable.
The text was updated successfully, but these errors were encountered:
req_template()
supports glue syntax, but loses the composability ofrequest() |> req_url_path_append()
. But paths are often also documented with glue-like syntax. For example, the apis.guru api has a/{provider}.json
path, whereprovider
is a path parameter (and the OpenAPI spec specifically allows suchpath
parameters).At first I thought this would need a new function, but in theory
req_url_path()
andreq_url_path_append()
could treat named arguments aspath
parameters, making these equivalent:It looks like only
dots_to_path
would need to be updated, and the tests look robust enough that it could be done safely, I think. I could probably whip up a PR if this sounds reasonable.The text was updated successfully, but these errors were encountered: