Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exporting should take into account multiple rules #11

Closed
asimmohiuddin opened this issue Jan 16, 2016 · 1 comment · Fixed by #13
Closed

Exporting should take into account multiple rules #11

asimmohiuddin opened this issue Jan 16, 2016 · 1 comment · Fixed by #13

Comments

@asimmohiuddin
Copy link
Contributor

@ahmedre
When multiple rules with the same index are exported by html exporter, there ends up being a problem in the output where characters are repeated. Is there an easy way to fix it? It is difficult trying to put logic for checking for #5 because it is like checking for that rule all over again. I think the best way to fix this is to handle repeated indexes by the exporter.

@asimmohiuddin
Copy link
Contributor Author

image

asimmohiuddin added a commit that referenced this issue Jan 16, 2016
The html exporter used substrings to apply rules to the html output. If there was an overlap then the parts of the substring may repeat. No matter what the exporter, there would always be a need to handle overlaps. Overlaps happen frequently with ghunna vs idghaam vs meem idghaam see issue #11. In this workaround, overlaps are removed all together. Also, ghunna is given the least preference and is always removed. Doing this at the sorting level will help remove the need of handling this in any future exporters. .
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant