#1407 improvements to audio settings #1429
Conversation
1.When I play a Surat then I go into settings to chose to play from what Surat to what Surat and I click play only above verses, the audio of the Surat will restart. It really shouldn't have to restart and should just apply the settings and keep playing. It makes it harder for the kids to focus because it repeats when I apply the settings. A. removed the part where audio playback is stopped if playing now it pauses and continues on pressing play if in selected range restarts to new start ayah if not in selected range 2.There should be an option to remember the last selected setting being "play only above verses". I'm always having to manually select it. A.modified 'refreshview()' to read from former used settings which where stored in sharedprefferences on pressing apply button
| @@ -172,6 +172,7 @@ dependencies { | |||
| androidTestImplementation "androidx.test.espresso:espresso-core:${espressoVersion}" | |||
| androidTestImplementation "androidx.test.espresso:espresso-intents:${espressoVersion}" | |||
| implementation 'com.crashlytics.sdk.android:crashlytics:2.10.1' | |||
| implementation 'com.google.code.gson:gson:2.8.6' | |||
There was a problem hiding this comment.
we already use moshi so let's not add gson
| package com.quran.labs.androidquran.dao.audio | ||
|
|
||
| import android.os.Parcelable | ||
| import com.quran.data.model.SuraAyah | ||
| import kotlinx.android.parcel.Parcelize | ||
|
|
||
| @Parcelize | ||
| data class AudioPlaybackSettings(val start: SuraAyah, | ||
| val end: SuraAyah, | ||
| val verseRepeatCount: Int = 0, | ||
| val rangeRepeatCount: Int = 0, | ||
| val enforceRange: Boolean = false) : Parcelable |
There was a problem hiding this comment.
what if, instead of doing this, we remove this class (and the corresponding changes to read/write this) - and instead do the work in the AudioService?
| if (player != null) { | ||
| player.stop(); | ||
| } | ||
| state = State.Stopped; | ||
| Crashlytics.log("stop if playing..."); |
There was a problem hiding this comment.
stopping is sometimes the right thing to do - but this is where we should check. you have the old audioRequest (before we override it in line 409). we can check for example if the current verse is within the range of playback (i.e. between oldAudioRequest.getStart() and oldAudioRequest.getEnd()), then don't stop. otherwise stop, and in either case, we'll replace the audioRequest.
There was a problem hiding this comment.
Thanks for the reply @ahmedre I will work on the changes as soon as possible
Ma'Assalam
1.When I play a Surat then I go into settings to chose to play from what Surat to what Surat and I click play only above verses, the audio of the Surat will restart. It really shouldn't have to restart and should just apply the settings and keep playing. It makes it harder for the kids to focus because it repeats when I apply the settings.
A. removed the part where audio playback is stopped if playing now it pauses and continues on pressing play if in selected range restarts to new start ayah if not in selected range
2.There should be an option to remember the last selected setting being "play only above verses". I'm always having to manually select it.
A.modified 'refreshview()' to read from former used settings which where stored in sharedprefferences on pressing apply button