Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Media Maker overflows for long verses #2206

Open
1 task done
rehandaphedar opened this issue Sep 23, 2024 · 0 comments
Open
1 task done

[bug]: Media Maker overflows for long verses #2206

rehandaphedar opened this issue Sep 23, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rehandaphedar
Copy link

Is there an existing issue for this?

  • There is no exsiting issue for this bug

Describe the bug

When using the Media Maker with longer verses, they will overflow out of the box and/or out of the screen unless using a very small font size.

I had a similar project a while back, and I faced a similar issue. I had used a hacky solution (calculating the number of characters in the verse and changing font size accordingly.

However, I think a better solution could be to split the verse into different phrases, based on the word timings for each recitation, as it would preserve the font size. Additionally, the changing font size solution sometimes would lead to weird results depending on the formula used.

image
image

Relevant log output

No response

Steps to reproduce

  1. Open Media Maker and enter any long verse, such as 2:282.

Environment (please complete the following information) and Add any other context about this bug

(Probably not relevant)
OS: Arch Linux
Browser: Firefox
Version: 130.0.1

Environment

Production(quran.com)

@rehandaphedar rehandaphedar added the bug Something isn't working label Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant