Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"Missing access token" error on (too early?) user profile retrieval #797

Open
KitsuneRal opened this issue Sep 8, 2024 · 1 comment · Fixed by #803
Open

"Missing access token" error on (too early?) user profile retrieval #797

KitsuneRal opened this issue Sep 8, 2024 · 1 comment · Fixed by #803
Assignees
@KitsuneRal
Labels
bug/fix The library doesn't work as expected

Comments

@KitsuneRal
Copy link
Member

Describe the bug
After porting Quaternion to libQuotient 0.9, I see that one-off "missing access token" error also reported on NeoChat. Apparently, the current Connection::assumeIdentity() code only sets the token after calling User::load() in C::P::completeSetup().
@KitsuneRal KitsuneRal added the bug/fix The library doesn't work as expected label Sep 8, 2024
@KitsuneRal KitsuneRal self-assigned this Sep 8, 2024
@KitsuneRal KitsuneRal linked a pull request Sep 20, 2024 that will close this issue
There's always place for more fixes #803
Merged
@KitsuneRal
Copy link
Member Author

Apparently #803 wasn't enough; GetUserProfileJob doesn't require an access token, and the functionality to add the access token upon 403 errors has been ripped out of the library (perhaps wrongly).

@KitsuneRal KitsuneRal reopened this Sep 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
bug/fix The library doesn't work as expected
Projects
libQuotient 1
Status: In work
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

There's always place for more fixes quotient-im/libQuotient
1 participant
@KitsuneRal