Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom room types shouldn't log spam #790

Open
redstrate opened this issue Aug 28, 2024 · 2 comments
Open

Custom room types shouldn't log spam #790

redstrate opened this issue Aug 28, 2024 · 2 comments
Labels
enhancement A feature or change request for the library

Comments

@redstrate
Copy link
Contributor

So I started using libQuotient in a project and it uses a custom room type for some functionality. However, libQuotient is not pleased about this at all. It will remind me constantly in another libQutoient consumer, for example NeoChat:

2024-08-28T15:14:30 [WARN ] quotient.events: /home/josh/kde/src/libquotient/Quotient/converters.cpp:13: void Quotient::_impl::warnUnknownEnumValue(const QString&, const char*): Unknown RoomType value: zone.xiv.astra-sync
2024-08-28T15:14:30 [WARN ] quotient.events: /home/josh/kde/src/libquotient/Quotient/converters.cpp:13: void Quotient::_impl::warnUnknownEnumValue(const QString&, const char*): Unknown RoomType value: zone.xiv.astra-sync
2024-08-28T15:14:30 [WARN ] quotient.events: /home/josh/kde/src/libquotient/Quotient/converters.cpp:13: void Quotient::_impl::warnUnknownEnumValue(const QString&, const char*): Unknown RoomType value: zone.xiv.astra-sync
2024-08-28T15:14:30 [WARN ] quotient.events: /home/josh/kde/src/libquotient/Quotient/converters.cpp:13: void Quotient::_impl::warnUnknownEnumValue(const QString&, const char*): Unknown RoomType value: zone.xiv.astra-sync
2024-08-28T15:14:30 [WARN ] quotient.events: /home/josh/kde/src/libquotient/Quotient/converters.cpp:13: void Quotient::_impl::warnUnknownEnumValue(const QString&, const char*): Unknown RoomType value: zone.xiv.astra-sync
2024-08-28T15:14:30 [WARN ] quotient.events: /home/josh/kde/src/libquotient/Quotient/converters.cpp:13: void Quotient::_impl::warnUnknownEnumValue(const QString&, const char*): Unknown RoomType value: zone.xiv.astra-sync
...
(a bunch more)

I can easily fix this, but I don't exactly how I should. Would it be enough to change this from a warning to a debug message or?

@redstrate redstrate added the enhancement A feature or change request for the library label Aug 28, 2024
@KitsuneRal
Copy link
Member

Now that I see the case I actually wonder if it's worth having this message at all. I guess, let's just drop it.

@redstrate
Copy link
Contributor Author

Now that I see the case I actually wonder if it's worth having this message at all. I guess, let's just drop it.

Drop the unknown enum value message mechanism entirely or just for this one case?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement A feature or change request for the library
Projects
None yet
Development

No branches or pull requests

2 participants