Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Governance message type to force transfer from an ICA account #1706

Open
joe-bowman opened this issue Aug 6, 2024 · 0 comments · May be fixed by #1712
Open

Add Governance message type to force transfer from an ICA account #1706

joe-bowman opened this issue Aug 6, 2024 · 0 comments · May be fixed by #1712

Comments

@joe-bowman
Copy link
Contributor

Summary

Due to a closed ICA channel, it can happen that a user makes a deposit, ICQ finds and recognises their deposit and correct allocates the qAsset pertaining to the deposit, but the subsequent ICA MsgSend from the DepositICA to the DelegateICA fails. There is no retry mechanism here, as we rely on the deposit account having a non-zero balance to trigger the deposit flow, so we must tie the deposit/receipt/mint flow with the send from DepositICA to DelegateICA.

This appears to have happened twice on ssc-1. Two deposits we made, recognised and the qSaga minted, but the deposit was never moved into the delegate account and delegated.

A governance message type should exist to forceTransfer from the depositAccount to another account (I can't see why this should be anything other than the delegate account, but this seems to restrictive - I feel we can safely move assets between any of the ICA accounts safely).

MsgICASend

srcAccount (string): port name of the source account e.g.: icacontroller-ssc-1.deposit
dstAccount (string): port name of the destination account e.g: icacontroller-scc-1.delegate
amount (sdk.Coins): amount to transfer
fromAddress: MUST be the governance account

@joe-bowman joe-bowman linked a pull request Aug 15, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant