Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Dashboard examples to main gallery #1135

Merged
merged 3 commits into from
Jun 10, 2024
Merged

Add Dashboard examples to main gallery #1135

merged 3 commits into from
Jun 10, 2024

Conversation

cwickham
Copy link
Collaborator

@cwickham cwickham commented Jun 6, 2024

  • Move dashboard examples to docs/gallery/
  • Remove docs/dashboards/examples
  • Edit internal links to docs/dashboards/examples to point to dashboards section of gallery
  • Add aliases to docs/gallery/index.qmd to catch anyone linking directly to docs/dashboards/examples

Closes quarto-dev/quarto-cli#9484

Copy link
Contributor

github-actions bot commented Jun 6, 2024

🚀 Deployed on https://deploy-preview-1135.quarto.org

@github-actions github-actions bot temporarily deployed to pull request June 6, 2024 18:57 Inactive
@cwickham cwickham marked this pull request as ready for review June 6, 2024 18:59
@cscheid
Copy link
Collaborator

cscheid commented Jun 8, 2024

I think this looks great - the one thought I have is wrt ordering of the different listings. I think the current order is ok, but I don't know if it was intentional or if we should do something else.

@cwickham
Copy link
Collaborator Author

@cscheid Yeah, I wondered too. At least the links at the top should be in the same order as the listings, so with that update the current ordering is:

  • Articles & Reports
  • Presentations
  • Dashboards
  • Websites
  • Books
  • Interactive Docs

This is the same order as in the Guide, which I think is an OK rationale... Any alternate proposal?

Copy link
Contributor

🚀 Deployed on https://deploy-preview-1135.quarto.org

@github-actions github-actions bot temporarily deployed to pull request June 10, 2024 17:41 Inactive
@cscheid
Copy link
Collaborator

cscheid commented Jun 10, 2024

This is good!

@cwickham cwickham merged commit 1575233 into main Jun 10, 2024
3 checks passed
@cwickham cwickham deleted the dashboard-gallery branch June 10, 2024 17:43
Copy link
Contributor

Successfully created backport PR for prerelease:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dashboard gallery should go into main gallery
2 participants