Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure RestService Mutiny WebClient created for HTTP protocol is closing WebClient and underlying Vert.X instance #1284

Open
michalvavrik opened this issue Sep 5, 2024 · 0 comments
Labels
priority/low lowest priority

Comments

@michalvavrik
Copy link
Member

Here you can see that client is not closed OOTB and neither is Vert.X: https://github.com/quarkus-qe/quarkus-test-framework/blob/main/quarkus-test-core/src/main/java/io/quarkus/test/bootstrap/RestService.java#L86

We already close it when we create Mutiny WebClient for HTTPS protocol: https://github.com/quarkus-qe/quarkus-test-framework/blob/main/quarkus-test-core/src/main/java/io/quarkus/test/bootstrap/RestService.java#L174

I suggest to do the same. Maybe give users to select scope (after each method, after all tests), but that is not necessary for us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/low lowest priority
Projects
None yet
Development

No branches or pull requests

1 participant