Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proof-of-concept to display unicode via the UC macro #446

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

guidoism
Copy link

@guidoism guidoism commented Jul 29, 2019

The current behavior displays an Any key with the text from the UC macro. This commit changes it to display the unicode character. The intent is to have a better experience if you are using the configurator just to view and tweak your keyboard.

There are several issues:

  • You can't compile a keyboard with UC directly from the configurator
  • You can't add unicode characters from the configurator
  • I changed it to not upper case the character if the code point is above 255 which is arbitrary and potentially confusing
  • I only made that change in one place, there are two other places where we do toUpperCase when the key is a single character but I don't understand what code path engages them
  • It might not work if the UC macro is within another macro

Again, this is a proof-of-concept. It seems like a simple enough change to merge but I don't want to add anything that would be confusing to future coders due to the half-assed nature of my code. Please let me know if there's anything I can do, other than adding full unicode support, which I don't think I'd be able to actually accomplish.

@yanfali

@noroadsleft noroadsleft requested a review from yanfali July 29, 2019 19:00
@noroadsleft noroadsleft added enhancement WIP Work in Progress labels Jul 29, 2019
@yanfali
Copy link
Collaborator

yanfali commented Jul 30, 2019

@guidoism can you upload a json file with an example? Thanks

@guidoism
Copy link
Author

Added file — See Layers 7 and 8.

unicode.txt

@yanfali
Copy link
Collaborator

yanfali commented Jul 30, 2019

So it's pretty cool. the question is how to integrate this. We could maybe add a new tab for unicode, but the bigger problem is I think we need API support in the form of data driven QMK that @skullydazed is working on.

@noroadsleft noroadsleft mentioned this pull request Nov 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants