Skip to content
This repository has been archived by the owner on Dec 11, 2023. It is now read-only.

Metadata .tsvs lost in replay with multiple metadata inputs #97

Open
ChrisKeefe opened this issue May 11, 2022 · 1 comment
Open

Metadata .tsvs lost in replay with multiple metadata inputs #97

ChrisKeefe opened this issue May 11, 2022 · 1 comment
Labels
blocked an external factor blocks progress on this issue bug Something isn't working

Comments

@ChrisKeefe
Copy link
Collaborator

When a command takes a .tsv and a .qza as metadata, the UUID of the .qza is captured, and the internal-use file name where the merged metadata was saved. As a result, Replay has no way of determining how many metadata inputs were originally passed, and is only able to render the handling of the .qza (and a warning message that there may be things missing). The same "masking" of inputs occurs when multiple .tsv files are passed.

Commands like longitudinal first-differences and empress plotting, which regularly take both a sample metadata tsv and one or more artifact as metadata cannot be replayed without manual editing in this case. This bug does not impact users who are re-running from captured metadata.

Metadata identity of some kind is probably a requirement for this fix, and may already be adequately supported in qiime2/qiime2#464

@ChrisKeefe ChrisKeefe added bug Something isn't working blocked an external factor blocks progress on this issue labels May 11, 2022
@ChrisKeefe
Copy link
Collaborator Author

CLI users impacted by this can add work around it by adding extra --m- parameter lines to their rendered scripts as needed. Artifact API users will need some_metadata.merge(other_metadata1, other_metadata_2, ...) to do the same.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
blocked an external factor blocks progress on this issue bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant