From 987ffee21813c43c739464170bb29d36b838e752 Mon Sep 17 00:00:00 2001 From: Hina Jajoo Date: Thu, 17 Oct 2024 14:46:40 -0700 Subject: [PATCH] Add UST Logging for Empty Trace Summary: There was a request to have UST log when traces are empty. We make a special case in the logger to log when the desired string is encountered Differential Revision: D64559516 --- libkineto/include/ILoggerObserver.h | 4 ++++ libkineto/src/CuptiActivityProfiler.cpp | 3 +-- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libkineto/include/ILoggerObserver.h b/libkineto/include/ILoggerObserver.h index d20fb1a8..b0bb4618 100644 --- a/libkineto/include/ILoggerObserver.h +++ b/libkineto/include/ILoggerObserver.h @@ -15,6 +15,10 @@ constexpr char kWarmUpStage[] = "Warm Up"; constexpr char kCollectionStage[] = "Collection"; constexpr char kPostProcessingStage[] = "Post Processing"; +// Special string in UST for determining if traces are empty +constexpr char kEmptyTrace[] = + "No Valid Trace Events (CPU/GPU) found. Outputting empty trace."; + #if !USE_GOOGLE_LOG #include diff --git a/libkineto/src/CuptiActivityProfiler.cpp b/libkineto/src/CuptiActivityProfiler.cpp index 0f742d4e..bef8825e 100644 --- a/libkineto/src/CuptiActivityProfiler.cpp +++ b/libkineto/src/CuptiActivityProfiler.cpp @@ -375,8 +375,7 @@ void CuptiActivityProfiler::processTraceInternal(ActivityLogger& logger) { } #endif // HAS_ROCTRACER if (!traceNonEmpty()) { - LOG(WARNING) - << "No Valid Trace Events (CPU/GPU) found. Outputting empty trace."; + LOG(WARNING) << kEmptyTrace; } for (const auto& session : sessions_) {