Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Any examples of using pyodide-build on an arbitrary build.py file which can be used by build tools like poetry to build the Emscripten + WASM wheel? #17

Open
jymchng opened this issue Aug 4, 2024 · 3 comments

Comments

@jymchng
Copy link

jymchng commented Aug 4, 2024

As titled.

Additionally, if this can work, then the building of the wheel and subsequent loading into pyodide can be much smoother.

It would be good to have an example showcasing something like setuptools.Extension or Cython.Extension and a build_ext.

Thank you.

@ryanking13
Copy link
Member

I don't have much experience with Poetry, so I don't know how build.py works, but we rely on a standard Python build system (PEP 517), so it Poetry's build.py is correctly supporting it. It would work.

It would be good to have an example showcasing something like setuptools.Extension or Cython.Extension and a build_ext.

PR welcome. As I mentioned, it would probably "just work", but if you run into any issues, it would be helpful if you could summarize what you're experiencing and open an issue or PR.

@jymchng
Copy link
Author

jymchng commented Aug 11, 2024

I don't have much experience with Poetry, so I don't know how build.py works, but we rely on a standard Python build system (PEP 517), so it Poetry's build.py is correctly supporting it. It would work.

It would be good to have an example showcasing something like setuptools.Extension or Cython.Extension and a build_ext.

PR welcome. As I mentioned, it would probably "just work", but if you run into any issues, it would be helpful if you could summarize what you're experiencing and open an issue or PR.

Thank you for your warm reply.

https://github.com/ymd-h/exodide?tab=readme-ov-file

I am looking for something like the above, but the project has not been maintained for two years so that is unfortunate. If pyodide can take over it, that will be great!

@ryanking13
Copy link
Member

ryanking13 commented Aug 12, 2024

That package was made when we didn't support out-of-tree builds. Now that we do, I don't think that package is necessary anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants