Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow CMI to be approximated with Chi-square in large-sample sizes? #98

Open
adam2392 opened this issue Jan 20, 2023 · 1 comment
Open
Labels
conditional-independence Related to CI testing

Comments

@adam2392
Copy link
Collaborator

          LGTM.  One comment.  The CMI value that is calculated as follows: 

val = hxyz - (hxz + hyz - hz).mean()

Doesn't this have an asymptotic chi-squared distribution under the null hypothesis? If so, should there be an option to calculate the p-value that way?

Originally posted by @robertness in #85 (review)

@adam2392
Copy link
Collaborator Author

LGTM. One comment. The CMI value that is calculated as follows:

val = hxyz - (hxz + hyz - hz).mean()

Doesn't this have an asymptotic chi-squared distribution under the null hypothesis? If so, should there be an option to calculate the p-value that way?

@robertness I'm not sure. I'm computing it as val = I(X;Y, Z) - I(X; Z), which is equivalent to the entropy definition you wrote I suppose. Is there a reference? I can add it in a follow-on PR.

@adam2392 adam2392 added the conditional-independence Related to CI testing label Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conditional-independence Related to CI testing
Projects
None yet
Development

No branches or pull requests

1 participant